Subversion SVN Changelog

Under Windows, display failing command lines in their quoted form.

The quoting can affect how the command is executed, so display the
quoted form to make it easier to debug the problem.

* subversion/tests/cmdline/svntest/main.py

(open_pipe): Under Windows, return the *quoted* command line as part
of the WAITER return value.

r878691: 2009-08-07 14:52:46 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/main.py [diff, log, file]

Return the command as a string, rather than as a list, from open_pipe().

The COMMAND value returned from open_pipe() as part of the WAITER
return value is only used to generate error messages, so return it as
a string rather than as a list of strings. Change wait_on_pipe()
accordingly.

* subversion/tests/cmdline/svntest/main.py

(open_pipe): Return the command as a string rather than as a list of
strings. Rename local variable command_list -> command_string to
reflect its new type.

(wait_on_pipe): Expect a string rather than a list of strings as the
second element of the WAITER argument. Rename local variable
command -> command_string to make its type more obvious.

r878690: 2009-08-07 13:16:48 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/main.py [diff, log, file]

Fix "command" return value under Windows.

For sys.platform == 'win32', the list of command arguments is turned
into a single string containing all of the arguments, quoted. But
this command string was also returned by the method, to callers who
expected it to be a list of strings. In the case of an error, this
return value is processed with ' '.join(), resulting in error messages
like "C : \ p a t h \ t o \ s v n . e x e a r g 1 a r g 2".

This change returns the commands as a list of strings regardless of
whether the command list is turned into a string internally.

Patch by: James Abbatiello <abbeyj@...>

* subversion/tests/cmdline/svntest/main.py

(open_pipe): Return the command list that was passed to the
function, regardless of whether it needs to be converted to a string
internally.

r878560: 2009-07-28 20:34:39 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/tree.py [diff, log, file]

Read svn properties in XML rather than text format in test suite.

This makes the routine more robust to strange property values. It also
makes it immune to changes in the text output format, as happened
between svn 1.5 and 1.6. (This is useful for the cvs2svn project,
which uses the svntest infrastructure but doesn't want to care what
version of svn the user has installed.)

* subversion/tests/cmdline/svntest/tree.py
(get_props): Read svn properties via "svn proplist -v" using the
"--xml" option.

r865863: 2007-07-19 11:24:51 [mhagger] Michael Haggerty

/notes/dump-load-format.txt [diff, log, file]

Fix dumpfile example in notes/dump-load-format.txt.

Approved by: Daniel Rall <dlr@...>

* notes/dump-load-format.txt: Fix character count for log message.

r865603: 2007-06-24 22:31:25 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/main.py [diff, log, file]

Don't gratuitously quote harmless command-line arguments.

If a command-line argument obviously doesn't need to be quoted, then
don't quote it. Using a conservative definition of "safe" that should
nevertheless greatly reduce the amount of gratuitous quotation.

* subversion/tests/cmdline/svntest/main.py (_safe_arg_re): New module
variable.

(_quote_arg): If the argument matches the regular expression in
_safe_arg_re, then don't quote it at all.

r865602: 2007-06-24 22:20:13 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/main.py [diff, log, file]

Extract a function to quote command-line arguments.

This is just a refactoring, with no change of functionality. More to
come...

* subversion/tests/cmdline/svntest/main.py (_quote_arg): New function,
using code taken from spawn_process().

(spawn_process): Use the new function for quoting command-line
arguments.

r862427: 2006-11-19 23:37:33 [mhagger] Michael Haggerty

/subversion/tests/cmdline/svntest/main.py [diff, log, file]
/subversion/tests/cmdline/svntest/testcase.py [diff, log, file]

Iff a TestCase needs a Sandbox, pass it in as a keyword argument.

Previously TestCase.run() was always passed a tuple argument, which
sometimes (depending on TestCase.need_sandbox()) contained a sandbox.

* subversion/tests/cmdline/svntest/testcase.py (TestCase.need_sandbox,
TestCase.get_sandbox_name): Add docstrings.

(TestCase.run): Make sandbox into a keyword argument, and add a
docstring that tells how the method will be called.

(FunctionTestCase.run): Make sandbox into a keyword argument, and
pass it to the delegate as a keyword argument.

* subversion/tests/cmdline/svntest/main.py (TestRunner.run): Pass
sandbox to test case as a keyword argument.

r861949: 2006-10-10 21:56:06 [mhagger] Michael Haggerty

/www/design.html [diff, log, file]

Add some missing spaces where words had somehow gotten mashedtogether.

* www/design.html: Add some missing spaces.

r859543: 2006-04-28 14:05:53 [mhagger] Michael Haggerty