Subversion SVN Changelog

Make svnserve SSL config items repo-conf-dir-relative, rather than absolute
paths.

* subversion/svnserve/serve.c
(find_repos): Prefix b->cert_file and b->key_file with the repo-conf-dir.

r859466: 2006-04-16 10:34:22 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/libsvn_subr/cmdline.c [diff, log, file]

Remove spurious whitespace change introduced in the shuffle of r19278 and
r19282.

* subversion/libsvn_subr/cmdline.c
(svn_cmdline_init): Revert whitespace change.

r859465: 2006-04-16 10:29:24 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/include/svn_ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/client.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ra_svn_endpoint.h  [log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [diff, log, file]
  [svnserve-ssl] /subversion/svnserve/main.c  [diff, log, file]
  [svnserve-ssl] /subversion/svnserve/serve.c  [diff, log, file]

Move new private functions out of public API.

Suggested by: Garrett Rooney <grooney@...>

* subversion/include/svn_ra_svn.h
(svn_ra_svn_conn_ssl_server, svn_ra_svn__ssl_initialize): Move to
new header file, renaming svn_ra_svn_conn_ssl_server to
svn_ra_svn__conn_ssl_server.

* subversion/libsvn_ra_svn/client.c:
#include "ra_svn_endpoint.h"

* subversion/libsvn_ra_svn/ssl.c:
#include "ra_svn_endpoint.h"
(svn_ra_svn_conn_ssl_server): Rename to svn_ra_svn__conn_ssl_server.

* subversion/libsvn_ra_svn/ra_svn_endpoint.h: New header file.

* subversion/svnserve/main.c:
#include "../libsvn_ra_svn/ra_svn_endpoint.h"

* subversion/svnserve/serve.c
#include "../libsvn_ra_svn/ra_svn_endpoint.h"
(auth_request): Call svn_ra_svn__conn_ssl_server, rather than
svn_ra_svn_conn_ssl_server.

r859442: 2006-04-14 10:54:02 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/libsvn_ra_svn/marshal.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/streams.c  [diff, log, file]

Hide the innards of svn_ra_svn_stream_t from the bulk of libsvn_ra_svn.

* subversion/libsvn_ra_svn/ra_svn.h
(svn_ra_svn_stream_t): Make opaque (move struct definition to streams.c).
(svn_ra_svn__stream_create, svn_ra_svn__stream_write,
svn_ra_svn__stream_read): New prototypes.

* subversion/libsvn_ra_svn/streams.c
(struct svn_ra_svn_stream): Define (moved from ra_svn.h).
(svn_ra_svn__stream_pair_from_files, svn_ra_svn__stream_pair_from_sock):
Call new constructor, rather than manually assembling the object.
(svn_ra_svn__stream_create): New constructor.
(svn_ra_svn__stream_write, svn_ra_svn__stream_read): New wrapper functions.

* subversion/libsvn_ra_svn/ssl.c
(network_biopair_interop): Call new wrapper functions, rather than
using the svn_stream interface directly.
(wrap_conn): Call new constructor, rather than manually assembling the
object.

* subversion/libsvn_ra_svn/marshal.c:
(writebuf_output, readbuf_input): Call new wrapper functions, rather than
using the svn_stream interface directly.

r859365: 2006-04-09 23:04:10 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c [diff, log, file]

Fix cert-processing bug that was preventing server trust from being cached.

* subversion/libsvn_ra_svn/ssl.c:
(fill_cert_info): Save a copy of the pointer to the allocated DER buffer
in, since i2d_X509() advances the pointer it is given, and stop needlessly
duplicating the base-64 value.

r859362: 2006-04-09 19:31:06 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/svnserve/serve.c [diff, log, file]

Gracefully degrade when svnserve doesn't have SSL compiled in, and when it
does but lacks the necessary configuration on the requested repository.

* subversion/svnserve/serve.c:
(SVNSERVE_CAN_TLS): New macro, TRUE iff SVN_HAVE_SSL.
(serve): Don't advertise STARTTLS support we don't have, and don't
reference repository-specific baton variables before find_repos()
has populated them.

r859358: 2006-04-09 05:09:52 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/include/svn_config.h  [diff, log, file]
  [svnserve-ssl] /subversion/include/svn_ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [diff, log, file]
  [svnserve-ssl] /subversion/svnserve/serve.c  [diff, log, file]

Add support for SSL to svnserve.

* subversion/include/svn_ra_svn.h
(svn_ra_svn_conn_ssl_server): New prototype.

* subversion/include/svn_config.h
(SVN_CONFIG_OPTION_SSL_SERVER_CERT_FILE,
SVN_CONFIG_OPTION_SSL_SERVER_KEY_FILE): New macros.

* subversion/libsvn_ra_svn/ssl.c
(ssl_last_error, svn_ra_svn_conn_ssl_server): New function.

* subversion/svnserve/serve.c
(server_baton_t): Add "cert_file" and "key_file" members.
(send_mechs): Add "showtls" parameter. Send STARTTLS as a
mechanism if showtls is TRUE.
(auth_request): Add "dotls" parameter. Initiate an SSL
connection if dotls is TRUE.
(must_have_access): Update auth_request call-site.
(find_repos): Populate the server baton with the cert_file
and key_file information from the cfg.
(serve): Update send_mechs and auth_request call-sites, and
refuse to support SSL for version 1 clients.

r859357: 2006-04-09 03:55:29 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/include/svn_io.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/marshal.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/streams.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_subr/stream.c  [diff, log, file]

Remove the ioctl interface added to svn_stream_t in r19258, and use a
wrapper object (svn_ra_svn_stream_t) instead.

Suggested by: Greg Hudson <ghudson@...>

* subversion/include/svn_io.h
(svn_stream_t): Update docstring.
(svn_ioctl_fn_t): Removed.
(svn_stream_set_ioctl, svn_stream_ioctl): Removed.

* subversion/libsvn_subr/stream.c
(struct svn_stream_t): Removed "ioctl_fn" member.
(svn_stream_set_ioctl, svn_stream_ioctl): Removed.

* subversion/libsvn_ra_svn/streams.c
(pending): Update interface to work more cleanly with the new
pending_fn_t interface.
(file_ioctl_cb): Split into file_timeout_cb and file_pending_cb.
(sock_ioctl_cb): Split into sock_timeout_cb and sock_pending_cb.
(file_timeout_cb, file_pending_cb, sock_timeout_cb, sock_pending_cb):
New functions.
(svn_ra_svn__stream_pair_from_files, svn_ra_svn__stream_pair_from_sock):
Update interfaces, create wrapper streams.
(svn_ra_svn__stream_timeout, svn_ra_svn__stream_pending): New functions.

* subversion/libsvn_ra_svn/ssl.c
(ssl_baton): Change datatype of "in" and "out" to svn_ra_svn_stream_t
from svn_stream_t.
(network_biopair_interop): Update stream call-sites.
(ssl_ioctl_cb): Split into ssl_timeout_cb and ssl_pending_cb.
(ssl_timeout_cb, ssl_pending_cb): New functions.
(wrap_conn): Create wrapper streams.

* subversion/libsvn_ra_svn/marshal.c
(svn_ra_svn__set_block_handler): Call svn_ra_svn__stream_timeout rather
than the ioctl interface.
(svn_ra_svn__input_waiting): Call svn_ra_svn__stream_pending rather than
the ioctl interface.
(writebuf_output, readbuf_input): Update stream call-sites.

* subversion/libsvn_ra_svn/ra_svn.h
(SVN_RA_SVN__IOCTL_TIMEOUT, SVN_RA_SVN__IOCTL_PENDING): Removed.
(pending_fn_t, timeout_fn_t): New callback types.
(svn_ra_svn_stream_t): New type.
(svn_ra_svn_conn_st): Change datatype of "in_stream" and "out_stream"
to svn_ra_svn_stream_t from svn_stream_t.
(svn_ra_svn__stream_pair_from_sock, svn_ra_svn__stream_pair_from_files):
Update prototype.
(svn_ra_svn__stream_timeout, svn_ra_svn__stream_pending): New prototypes.

r859356: 2006-04-09 02:03:48 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/include/svn_ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/client.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_subr/cmdline.c  [diff, log, file]
  [svnserve-ssl] /subversion/svnserve/main.c  [diff, log, file]

Move SSL initialization to a more appropriate place.

* subversion/include/svn_ra_svn.h
(svn_ra_svn__ssl_initialize): New function prototype.
* subversion/libsvn_subr/cmdline.c:
(svn_cmdline_init): Remove SSL initialization.
* subversion/libsvn_ra_svn/client.c
(svn_ra_svn__init): Call svn_ra_svn__ssl_initialize().
* subversion/libsvn_ra_svn/ssl.c
(svn_ra_svn__ssl_initialize): New function.
* subversion/svnserve/main.c
(main): Call svn_ra_svn__ssl_initialize().

r859352: 2006-04-08 23:38:32 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/libsvn_subr/cmdline.c [diff, log, file]

Initialize OpenSSL.

* subversion/libsvn_subr/cmdline.c
(svn_cmdline_init): Add calls to OpenSSL's initializers.

r859349: 2006-04-08 23:26:19 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/include/svn_error_codes.h  [diff, log, file]
  [svnserve-ssl] /subversion/include/svn_ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/client.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ssl.c  [log, file]

Add client-side support for SSL in the Subversion protocol.

Note: this implementation won't be useful until server-side
support is added.

Patch by: Sigfred Håversen <bsdlist@...>
(Tweaked by me.)

* subversion/include/svn_error_codes.h
(SVN_ERR_RA_SVN_SSL_INIT, SVN_ERR_RA_SVN_SSL_ERROR): New errors.
* subversion/include/svn_ra_svn.h
(SVN_RA_SVN_CAP_STARTTLS): New macro.
* subversion/libsvn_ra_svn/client.c
(ra_svn_session_baton_t): Add "hostname" member.
(do_auth): Handle "STARTTLS" mechanism.
(open_session): Store uri->hostname in sess, and present
SVN_RA_SVN_CAP_STARTTLS to the server as a capability.
* subversion/libsvn_ra_svn/ssl.c: New file.
* subversion/libsvn_ra_svn/ra_svn.h:
#include "svn_auth.h"
(svn_ra_svn__conn_ssl_client): New function prototype.

r859340: 2006-04-08 16:03:55 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/libsvn_ra_svn/streams.c [diff, log, file]

Revert accidentally introduced piece of r19264.

* subversion/libsvn_ra_svn/streams.c
(sock_read_cb): Don't save and restore the timeout.

r859339: 2006-04-08 15:42:19 [mbk] Mark Benedetto King

  [svnserve-ssl] /aclocal.m4  [diff, log, file]
  [svnserve-ssl] /build.conf  [diff, log, file]
  [svnserve-ssl] /build/ac-macros/ssl.m4  [log, file]
  [svnserve-ssl] /configure.in  [diff, log, file]
  [svnserve-ssl] /Makefile.in  [diff, log, file]

Add configury for OpenSSL detection.

Patch by: Sigfred Håversen <bsdlist@...>
(Tweaked by me.)

* Makefile.in
(SVN_SSL_LIBS): New autoconf-provided macro.
(INCLUDES): Updated to include SVN_SSL_INCLUDES, an autoconf-provided
macro.
* build.conf
([svn], [svnserve]): Add dependant library "ssl".
([ssl]): New library definition.
* configure.in: Add call to SVN_LIB_SSL.
* build/ac-macros/ssl.m4: New file.
* aclocal.m4: Include build/ac-macros/ssl.m4.

r859338: 2006-04-08 15:31:41 [mbk] Mark Benedetto King

  [svnserve-ssl] /subversion/libsvn_ra_svn/client.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/marshal.c  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/ra_svn.h  [diff, log, file]
  [svnserve-ssl] /subversion/libsvn_ra_svn/streams.c  [log, file]

Encapsulate ra_svn's i/o with a stream-based wrapper.

This does clean things up slightly, but it is principally to
facilitate the subsequent introduction of an SSL integration
layer.

Patch by: Sigfred Håversen <bsdlist@...>
(Tweaked by me.)

* subversion/libsvn_ra_svn/client.c
(make_tunnel): Remove (now)-obsolete population of the connections "proc"
member.
* subversion/libsvn_ra_svn/streams.c: New file.
* subversion/libsvn_ra_svn/marshal.c:
#include "svn_io.h"
(svn_ra_svn_create_conn): Don't initialize obsolete members of the
connection, instead use the new svn_ra_svn__stream_pair_from_* functions
to initialize the new stream members.
(svn_ra_svn__set_block_handler, svn_ra_svn__input_waiting, writebuf_output,
readbuf_input): Use the stream API on the new members, rather than the
APR socket and pipe APIs on the old.
* subversion/libsvn_ra_svn/ra_svn.h
(SVN_RA_SVN__IOCTL_TIMEOUT, SVN_RA_SVN__IOCTL_PENDING): New macros.
(struct svn_ra_svn_conn_st): Remove "in_file", "out_file", and "proc"
members in favor of "in_stream" and "out_stream".
(svn_ra_svn__stream_pair_from_sock, svn_ra_svn__stream_pair_from_files):
New function prototypes.

r859332: 2006-04-08 14:10:11 [mbk] Mark Benedetto King

[svnserve-ssl] /subversion/include/svn_io.h [diff, log, file]
[svnserve-ssl] /subversion/libsvn_subr/stream.c [diff, log, file]

Add ioctl support to the svn_stream interface.

* subversion/include/svn_io.h
(svn_stream_t): Update docstring.
(svn_ioctl_fn_t): New callback type.
(svn_stream_set_ioctl, svn_stream_ioctl): New function prototypes.

* subversion/libsvn_subr/stream.c
(struct svn_stream_t): Add new "ioctl_fn" member.
(svn_stream_set_ioctl, svn_stream_ioctl): New functions.

r859331: 2006-04-08 14:06:13 [mbk] Mark Benedetto King

[svnserve-ssl] / [log, file] (copied from r859330 of /)

Rebranch svnserve-ssl from trunk (see r19256 for details).

r859330: 2006-04-08 14:04:26 [mbk] Mark Benedetto King

[svnserve-ssl] / [old log]

Remove svnserve-ssl branch, with the intent of rebranching
from trunk and rebuilding the svnserve-ssl functionality
through a sequence of reviewable changes.

r859114: 2006-03-26 15:26:13 [mbk] Mark Benedetto King

/subversion/tests/cmdline/schedule_tests.py [diff, log, file]

Constrain schedule_tests 25 (delete_non_existent) to a test WC.

This prevents unpleasantness such as WC-format bumps in the source WC.

Patch by: Lieven Govaerts <lgo@...>

* tests/cmdline/schedule_tests.py
(delete_non_existent): chdir before running svn.

r859113: 2006-03-26 14:25:29 [mbk] Mark Benedetto King

  /build/ac-macros/apr.m4  [diff, log, file]
  /build/ac-macros/aprutil.m4  [diff, log, file]
  /configure.in  [diff, log, file]

Make configure handle new (and future) APR/APR-UTIL versions by passing
a list of space-separated regexes to their respective macros.

* configure.in:
Update acceptable version regexes for APR and APR-UTIL.

* build/ac-macros/aprutil.m4 (SVN_LIB_APRUTIL),
* build/ac-macros/apr.m4 (SVN_LIB_APR):
Loop through all acceptable version regexes, looking for a match.

r859112: 2006-03-25 18:01:16 [mbk] Mark Benedetto King

/subversion/libsvn_ra_dav/session.c [diff, log, file]

Fix issue 2360: svn switch --relocate not caching auth creds

* subversion/libsvn_ra_dav/session.c
(svn_ra_dav__do_get_uuid): Store auth info after successful request.

r857703: 2005-12-05 12:21:50 [mbk] Mark Benedetto King

/subversion/libsvn_fs_base/reps-strings.c [diff, log, file]

Replace the "unknown_node_kind" helper function with a macro,
"UNKNOWN_NODE_KIND", in order to preserve line-number information
in errors.

Suggested by: rooneg

* subversion/libsvn_fs_base/reps-strings.c
(unknown_node_kind): Remove.
(UNKNOWN_NODE_KIND): New macro.
(rep_read_range, svn_fs_base__delete_rep_if_mutable,
svn_fs_base__rep_contents_size, rep_write, svn_fs_base__rep_deltify):
Use the new macro, rather than the helper function.

r857699: 2005-12-05 00:53:39 [mbk] Mark Benedetto King

/subversion/libsvn_fs_base/reps-strings.c [diff, log, file]

Generate error messages when certain types of repository corruption
are detected, rather than calling abort(), which could potentially
worsen the already bad situation.

* subversion/libsvn_fs_base/reps-strings.c
(unknown_node_kind): New helper function.
(rep_read_range, svn_fs_base__delete_rep_if_mutable,
svn_fs_base__rep_contents_size, rep_write, svn_fs_base__rep_deltify):
Return an error, rather than calling abort().

r857693: 2005-12-04 02:16:04 [mbk] Mark Benedetto King

  /build.conf  [diff, log, file]
  /configure.in  [diff, log, file]
  /Makefile.in  [diff, log, file]
  /subversion/include/svn_auth.h  [diff, log, file]
  /subversion/libsvn_subr/cmdline.c  [diff, log, file]
  /subversion/libsvn_subr/simple_providers.c  [diff, log, file]

On Mac OS, use KeyChain services to store password (Issue 2339).

Note: SecKeychainSetUserInteractionAllowed (FALSE) does not appear to
actually prevent all user interaction. Specifically, if the executable
changes (for example, if it is rebuilt), the system prompts the user
to okay the use of the new executable.

I'm not sure if I'm doing something wrong, or if this is a genuine bug
in the KeyChain implementation itself.

Suggested by: Wilfredo Sánchez <wsanchez@...>
Patch by: Ken Allan <k.allan@...>
Wilfredo Sánchez <wsanchez@...>
me
Review by: djames

* Makefile.in:
Add SVN_KEYCHAIN_LIBS, an autoconf substituted variable.
Add SVN_KEYCHAIN_INCLUDES to INCLUDES.

* build.conf:
Define keychain, an external lib, using the SVN_KEYCHAIN_LIBS variable.
Add keychain to the libs for the svn exe.

* configure.in:
Add --enable-keychain/--disable-keychain configury. Default to enabled,
if the appropriate OS and version are detected.

* subversion/include/svn_auth.h:
(svn_auth_get_keychain_simple_provider): New prototype.

* subversion/libsvn_subr/cmdline.c:
#include "svn_auth.h"
(svn_cmdline_setup_auth_baton): Add keychain provider to list,
and though not strictly required, increase the initial array size
accordingly.

* subversion/libsvn_subr/simple_providers.c:
#include "svn_private_config.h"
(SVN_AUTH__KEYCHAIN_PASSWORD_TYPE): New password-type macro.
Conditionally #include <Security/Security.h>
(keychain_password_set, keychain_password_get, keychain_simple_first_creds,
keychain_simple_save_creds, svn_auth_get_keychain_simple_provider): New
functions.
(keychain_simple_provider): New svn_auth_provider_t instance.

r857690: 2005-12-03 22:26:12 [mbk] Mark Benedetto King

/subversion/libsvn_subr/simple_providers.c [diff, log, file]

Pass the "non-interactive" flag into the password storage/retrieval
implementations internal to the simple auth providers (in preparation
for adding Mac OS X Keychain support).

* subversion/libsvn_subr/simple_providers.c:
(password_set_t, password_get_t, simple_password_get, simple_password_set,
windows_password_encrypter, windows_password_decrypter): Update doc string,
add "non_interactive" parameter.
(simple_first_creds_helper, simple_save_creds_helper): Pull the
"non_interactive" flag from authentication parameters and pass it along.

Select page:

Previous Page 1 2 3 5 7 9