Subversion SVN Changelog

Changelog for Subversion (557 revisions):

r989670: 2010-08-26 13:19:20 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Nominate r989658.

r989658: 2010-08-26 13:06:28 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/version.c  [diff, log, file]

 [issue3695] Fix issue 3695.
 
 "SVNPathAuthz short_circuit ignores the authz path rules with repo prefix."
 
 * subversion/mod_dav_svn/version.c
   (): include "mod_dav_svn.h" as we need 'dav_svn_split_uri'.
   (deliver_report): 'resource->info->repos->repo_name' is NULL when
    SVNPathAuthz is short circuited. So populate it for the 'reponame'
    based authz rules to work.

r979318: 2010-07-26 14:42:38 [kameshj] Kamesh Jayachandran

  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 svnrdump <unknown_command> url_to_valid_repo causes segfault
 
 * subversion/svnrdump/svnrdump.c
   (main): handle the error cases when unknown_command is given and *no*
    subcommand given.

r979306: 2010-07-26 14:27:56 [kameshj] Kamesh Jayachandran

  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 'svnrdump --version' should show the ra layer modules it is linked with
 like 'svn' and 'svnsync'.
 
 * subversion/svnrdump/svnrdump.c
   (version): print the ra_module info.

r955273: 2010-06-16 15:31:01 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 *STATUS: (r917523) clarify 'encodable'

r955259: 2010-06-16 15:19:16 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 *STATUS: describe the bug r916286, r917512 fixes

r933251: 2010-04-12 14:19:23 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 *STATUS: Propose r933194 for backport.

r933194: 2010-04-12 11:26:28 [kameshj] Kamesh Jayachandran

  /subversion/mod_authz_svn/mod_authz_svn.c  [diff, log, file]

 [issue2753] Fix issue 2753.
 
 Relax requests aimed at the repo Parent path from authz control.
 
 * subversion/mod_authz_svn/mod_authz_svn.c
   (create_authz_svn_dir_config): Canonicalize conf->base_path.
   (req_check_access): When canonicalized 'uri' and 'conf->base_path' are same
    allow the request.
   (access_checker, check_user_id, auth_checker):
    Initialize repos_path to 'NULL' otherwise it can point
    to stray values when req_check_access relaxes certain requests without
    initialising the out parameters.

r931948: 2010-04-08 14:00:07 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/mirror.c  [diff, log, file]

 Follow-up to review comment on 'r917523'.
 
 'svn_path_uri_encode' returns 'const char*' no need to type cast it to 'char*'
 when assigning to 'const char*' identifiers(Copy paste mistake!!)
 
 * subversion/mod_dav_svn/mirror.c
   (dav_svn__location_in_filter,
    dav_svn__location_header_filter,
    dav_svn__location_body_filter): Remove unwanted typecast.
 
 Suggested by: julianfoad

r928802: 2010-03-29 15:05:29 [kameshj] Kamesh Jayachandran

  /subversion/libsvn_repos/load.c  [diff, log, file]

 Typo fix and indentation fix no-functional change.
 
 * subversion/libsvn_repos/load.c
   (renumber_mergeinfo_revs): Typo fix 'revsions'->'revisions'.
    Maintain '2' space indentations consistently.

r928793: 2010-03-29 14:49:19 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Vote and approve issue #3020 group.

r917535: 2010-03-01 14:04:17 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/mod_dav_svn.c  [diff, log, file]

 Follow-up to r916286 & r917512.
 
 * subversion/mod_dav_svn/mod_dav_svn.c
 (create_dir_config): Add a comment that 'dir' is always a URI in SVN context.
 
 Suggested by: julianfoad

r917532: 2010-03-01 13:59:03 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Nominate r917523.

r917525: 2010-03-01 13:55:14 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Nominate r917512 to r916286 group.

r917523: 2010-03-01 13:48:01 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/mirror.c  [diff, log, file]

 With the below apache configuration(See the <space> character "/svn 1/").
 
 <Location "/svn 1/">
   DAV svn
   SVNParentPath /repositories
 </Location>
 <Location "/svn 2/">
   DAV svn
   SVNParentPath /repositories-slave
   SVNMasterURI "http://localhost/svn 1"
 </Location>
 
 Write through proxy is *not* happening and commit happens *directly* inside the slave.
 
 * subversion/mod_dav_svn/mirror.c
   (proxy_request_fixup): URI encode the to be proxied file name.
   (dav_svn__proxy_request_fixup): r->unparsed_uri is in url encoded form while
     root_dir is not in encoded form. So use r->uri to compare with root_dir.
   (dav_svn__location_in_filter): URL Encode the 'find & replace' urls as
     the request body has it in url encoded format.
   (dav_svn__location_header_filter): Encode the master_uri as the response from
     master has the Location header url encoded already. Set the outgoing Location
     header url encoded.
   (dav_svn__location_body_filter): URL Encode the 'find & replace' urls as
     the response body has it in url encoded format.

r917512: 2010-03-01 13:15:58 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/mirror.c  [diff, log, file]
  /subversion/mod_dav_svn/mod_dav_svn.c  [diff, log, file]

 Follow-up to r916286.
 
 * subversion/mod_dav_svn/mod_dav_svn.c
   (create_dir_config):
 
 * subversion/mod_dav_svn/mirror.c
   (dav_svn__location_in_filter, dav_svn__location_body_filter):
    Use 'svn_uri_canonicalize' on url paths.
 
 Found by: julianfoad, rhuijben

r916322: 2010-02-25 15:25:45 [kameshj] Kamesh Jayachandran

  [1.6.x-r916286] /  [old log]

 Deleting, will create if the other group of revisions are not approved.

r916321: 2010-02-25 15:23:47 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Nominate r916286.

r916319: 2010-02-25 15:18:54 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 * STATUS: Nominate r878590, r878607, r878625, r878626, r878627.

r916289: 2010-02-25 13:54:47 [kameshj] Kamesh Jayachandran

  [1.6.x-r916286] /  [log, file]  (copied from r916288 of [1.6.x] /)

 * branches/1.6.x-r916286: New branch to merge r916286 to 1.6.x.

r916286: 2010-02-25 13:40:22 [kameshj] Kamesh Jayachandran

  /subversion/mod_dav_svn/dav_svn.h  [diff, log, file]
  /subversion/mod_dav_svn/mirror.c  [diff, log, file]
  /subversion/mod_dav_svn/mod_dav_svn.c  [diff, log, file]

 With the below apache configuration(See the trailing slash at the end of '/svn/').
 
 <Location /svn/>
   DAV svn
   SVNParentPath /repositories
 #See the trailing slash on the master URI also can cause the confusion.
   SVNMasterURI http://master/svn/
   SVNAdvertiseV2Protocol Off
 </Location>
 
 
 We get the following error on the client side.
 
 svn: Commit failed (details follow):
 svn: MKACTIVITY of '/svn/demujin/!svn/act/4b6d547c-018d-4e02-9d3f-2b283076cc06': Could not read status line: connection was closed by server (http://localhost)
 
 
 On the server(proxy) it is an assertion error on the following code block from subversion/mod_dav_svn/mirror.c:proxy_request_fixup
 
    assert((uri_segment[0] == '\0')
            || (uri_segment[0] == '/'));
 
 For the above configuration we get the uri_segment with the value 'reponame/some/path/inside/the/repo'.
 
 We fix this by canonicalizing the 'root_dir'(The one in Location) and
 'uri.path'(Path portion of Master URI).
 * subversion/mod_dav_svn/dav_svn.h
 (dav_svn__get_root_dir): Document that root_dir is in canonicalized form.
 * subversion/mod_dav_svn/mod_dav_svn.c
 (create_dir_config): Canonicalize the root_dir.
 * subversion/mod_dav_svn/mirror.c
 (dav_svn__location_in_filter, dav_svn__location_body_filter):
 As root_dir is in canonical form canonicalize the uri.path too to avoid
 spurious errors.
 (dav_svn__location_header_filter): As root_dir is canonical we need to
  explicitly introduce the path seperator.
 
 Suggested by: julianfoad

r905580: 2010-02-02 11:09:44 [kameshj] Kamesh Jayachandran

  [1.6.x] /STATUS  [diff, log, file]

 Vote for r905326

r905564: 2010-02-02 10:19:45 [kameshj] Kamesh Jayachandran

  [1.6.x-r905326] /  [diff, log, file]
  [1.6.x-r905326] /CHANGES  [diff, log, file]
  [1.6.x-r905326] /subversion/libsvn_ra_serf/commit.c  [diff, log, file]

 * branches/1.6.x-r905326:
   Merge r905326 from trunk, resolving conflicts.

r905545: 2010-02-02 08:58:40 [kameshj] Kamesh Jayachandran

  [1.6.x-r905326] /  [log, file]  (copied from r905544 of [1.6.x] /)

 * branches/1.6.x-r905326: New branch to merge r905326 to 1.6.x.

r905326: 2010-02-01 16:29:35 [kameshj] Kamesh Jayachandran

  /subversion/libsvn_ra_serf/commit.c  [diff, log, file]

 [issue3561]
 Follow-up commit similar to r900797 for ra_serf layer committing to
 http-v2 unaware proxy.
 
 Make CHECKOUT request on VCC url rather than the baseline url as that avoids
 the detection of *out of date* baseline url from the mirror and leave that
 to CHECKOUT itself via '<D:apply-to-version/>'.
 
 As CHECKOUT is proxied by the mirror we are not getting hit by the original
 issue.
 
 * subversion/libsvn_ra_serf/commit.c
 (commit_context_t): Replace baseline_url with vcc_url.
 (create_checkout_body): Make CHECKOUT body to have '<D:apply-to-version/>'.
 (checkout_dir): Make CHECKOUT on vcc_url instead of baseline url.
 (open_root): Remove baseline url detection code.