Subversion SVN Changelog

Changelog for Subversion (79 revisions):

r993102: 2010-09-06 17:27:59 [artagnon] User: artagnon

  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 * subversion/svnrdump/svnrdump.c
   (main): Dump only the single specified revision number when only one
   is passed to the '-r' option.
   (svnrdump__cmd_table, svnrdump__options): Track this change in the
   usage strings.
 
 Patch by: Vijayaguru G <vijay@...>

r987530: 2010-08-20 14:56:32 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 * subversion/svnrdump/svnrdump.c
   (load_cmd): A closer look shows that r987513 doesn't do what it
   promises. Revert it.
 
 * subversion/svnrdump/load_editor.c
   (drive_dumpstream_loader): Add a TODO note about trying to find out
   if we can set the revprops.
 

r987513: 2010-08-20 14:08:42 [artagnon] User: artagnon

  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 * subversion/svnrdump/svnrdump.c
   (load_cmd): Check that we can set revprops before attempting to
   drive the load editor.

r986754: 2010-08-18 15:55:19 [artagnon] User: artagnon

  /build.conf  [diff, log, file]
  /subversion/svnrdump/svnrdump.1  [diff, log, file]
  /subversion/svnrdump/svnrdump.c  [diff, log, file]

 * subversion/svnrdump/svnrdump.1: Update the description of svnrdump
   to reflect the fact that it does both dumping and loading now.
 * subversion/svnrdump/svnrdump.c (svn_opt_subcommand_desc2_t):
   Update the description of the load subcommand to reflect that the
   functionality is now ready.
 * build.conf (svnrdump): Update the description of svnrdump to reflect
   the fact that it does both dumping and loading now.
 
 Approved by: danielsh

r986567: 2010-08-18 05:34:27 [artagnon] User: artagnon

  /subversion/svnrdump/dump_editor.c  [diff, log, file]

 * subversion/svnrdump/dump_editor.c
   (open_file): Followup r986466 to fix a silly mistake concerning the
   order of the arguments in svn_relpath_join.
 
 Found by: rhuijben

r986566: 2010-08-18 05:26:55 [artagnon] User: artagnon

  [ra-uuid] /  [old log]

 * branches/ra-uuid: Remove branch. We have determined that this is a
   bad idea from a discussion on the mailing list.

r986466: 2010-08-17 19:48:32 [artagnon] User: artagnon

  /subversion/svnrdump/dump_editor.c  [diff, log, file]

 * subversion/svnrdump/dump_editor.c
   (open_file): Simplify a block of code that pushes to an array and
   then calls svn_path_compose; use svn_relpath_join instead.

r984496: 2010-08-11 17:56:06 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record): Without sufficient information in the
   revprop_table, we cannot create the commit_editor. Make this clear
   by not looking for the revprop_table first and add a comment about
   this.

r984463: 2010-08-11 16:29:11 [artagnon] User: artagnon

  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/tests/cmdline/svnrdump_tests.py
   (copy_and_modify_dump, copy_and_modify_load): Modify docstrings to
   reflect that they're two different tests.
 
 Suggested by: danielsh

r983266: 2010-08-07 17:38:01 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record): For closing directories, use the lighter
   svn_path_component_count instead of svn_path_decompose, since we
   don't need the individual components to close directories. Also,
   don't tax the rb->pool unnecessarily- use the scratch pool for the
   local variables.

r983263: 2010-08-07 17:29:47 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 svnrdump: Fix the failing skeleton_load test.
 
 * subversion/svnrdump/load_editor.c
   (new_node_record): Use the APR_ARRAY_IDX macro instead of attempting
   to access an element by hand.
   
 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): Pass the skeleton_load test.
 
 Suggested by: danielsh

r983261: 2010-08-07 17:20:43 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (set_revision_property): Wrap the svn_ra_change_rev_prop call in
   SVN_ERR.
 
 Found by: danielsh

r983255: 2010-08-07 16:23:23 [artagnon] User: artagnon

  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): r983248 breaks skeleton_load test on ra_local and
   ra_svn. Mark it XFail appropriately.

r983248: 2010-08-07 15:41:20 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 svnrdump: Rework the directory baton linked-list code in the load
 editor fixing crashes that went unnoticed earlier.
 
 * subversion/svnrdump/load_editor.c (new_node_record):
 
   residual_path needs to be split into two separate variables:
   residual_close_path and residual_open_path because they're
   fundamentally asymmetric; (number of directories to close) is not
   necessarily equal to (number of directories to subsequently open to
   get where we want): DFS only guarantees that former number is less
   than or equal to the latter, although we're not using this property.
 
   Correct the arguments in the call to svn_path_compare_paths, and
   replace nb->path by the dirname of nb->path; it makes no sense to
   compare a path *with* a filename against one that does not. For
   directories, add_directory takes care of adding to the linked-list
   anyway.
 
   In add_directory, correct the relpath of the child_baton: there's no
   need to invoke some complex appending logic- provided that the code
   prior to reaching points works fine and calls open_directory
   appropriately, the relpath should just be the path of the directory
   in nb->path.
 
   When creating a new child_baton, don't forget to set the parent.

r983222: 2010-08-07 12:31:50 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 svnrdump: Fix a bug in the load_editor; it was unable to handle
 revisions without node information previously.
 
 * subversion/svnrdump/load_editor.c
   (close_revision): Add a new if-branch; if the commit_editor doesn't
   exist, create one, open_root and close_edit on it to indicate that
   we've finished processing the revision. While at it, also fix
   indentation.

r983096: 2010-08-06 19:10:20 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/svnrdump/load_editor.h  [diff, log, file]

 svnrdump: Fix a bug involving svn_node_action_delete
 
 * subversion/svnrdump/load_editor.c
   (new_node_record, apply_textdelta, close_node): Fix the tense of the
   LDR_DBG messages.
   (new_node_record): Extract base_checksum header. Also, no Node-Kind
   information is present during a svn_node_action_delete, so don't
   look for it and blindly delete the given entry.
   (apply_textdelta): Use the extracted base_checksum while applying
   the textdelta.
 
 * subversion/svnrdump/load_editor.h
   (node_baton): Add a new base_checksum field.

r982964: 2010-08-06 13:56:42 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record): Handle the open_file case and fix the
   fall-through in the switch case statement.
 
 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): Pass the skeleton_load and copy_and_modify_load
   tests. These were fixed by rhuijben in r982957.

r982948: 2010-08-06 13:17:31 [artagnon] User: artagnon

  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): Mark skeleton_load and copy_and_modify_load as Wimp
   only for ra_dav. They pass with ra_svn now.

r982929: 2010-08-06 11:05:58 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (apply_textdelta, close_node): Move the call to close_file from
   apply_textdelta to close_node, relying on the fact that
   apply_textdelta will always be called after a file is opened or
   added.
 
 Found by: rhuijben
 Suggested by: danielsh

r982918: 2010-08-06 10:07:13 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record): Canonicalize the initial relpath.
   (new_node_record): After an add_directory, add the child_baton to
   the directory baton linked list.
 
 Noticed by: rhuijben

r982900: 2010-08-06 07:41:51 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/svnrdump/load_editor.h  [diff, log, file]

 svnrdump: Make the load editor respect the rules of an
 svn_delta_editor_t strictly by calling open_directory and
 close_directory where appropriate.
 
 * subversion/svnrdump/load_editor.h
 
   (parse_baton): Remove pool and use the one in the revision_baton
   instead.
 
   (directory_baton): New structure to wrap the unexposed dir_context_t
   in commit.c. This is useful to keep track of how deep our directory
   baton is and provide a link the the parent.
 
   (revision_baton): Change the type of the directory baton from void *
   to struct directory_baton *.
 
 * subversion/svnrdump/load_editor.c
 
   (new_revision_record, new_node_record, set_revision_property,
   set_node_property, delete_node_property, apply_textdelta,
   close_revision): Track the change in the pool's location.
 
   (new_node_record): While creating the commit_editor, also create a
   toplevel directory baton. Add some logic to open and close
   directories and set the directory baton appropriately depending on
   how much the dirname of the file we're adding differs from the our
   current directory baton's path.
 
   (close_revision): Close any open directories before closing the edit
   session itself.

r982863: 2010-08-06 03:53:04 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record): Remove incorrect comment about the historical
   detail in the commit editor, and handle the svn_node_action actions/
   svn_node_kind_t file and dir kind explicitly.
   (set_revision_property): Remove an extra pair of brackets.
   (remove_node_props): Add a comment about this function not being
   implemented.
   (apply_textdelta): Close the file after apply the textdelta.
   (close_node): Remove the close_file, close_directory calls from
   here. It's incorrect to put them here.
   (close_revision): Add a close_directory call corresponding to the
   toplevel open_root.
 
 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): Mark copy_and_modify_load as failing for ra_svn, as it
   only seemed to work by accident.

r981966: 2010-08-03 17:07:16 [artagnon] User: artagnon

  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 * subversion/tests/cmdline/svnrdump_tests.py
   (test_list): Mark the skeleton_load and copy_and_modify_load tests
   as Wimp only for ra_dav; they've been fixed for ra_svn in r981876.

r981876: 2010-08-03 13:45:21 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/svnrdump/load_editor.h  [diff, log, file]

 * subversion/svnrdump/load_editor.c
   (new_node_record, set_revision_property): Don't use repos_url from
   the comit_edit_baton. Use svn_ra_get_repos_root2 in
   set_revision_property instead. Also, use svn_path_url_add_component2
   instead of svn_uri_join so that escaping is handled properly.
 
 * subversion/svnrdump/load_editor.h
   (commit_edit_baton): Remove structure as it's not required anymore.
   (parse_baton): Add a new root_url field.

r981266: 2010-08-01 16:42:04 [artagnon] User: artagnon

  /subversion/svnrdump/load_editor.c  [diff, log, file]
  /subversion/svnrdump/load_editor.h  [diff, log, file]
  /subversion/tests/cmdline/svnrdump_tests.py  [diff, log, file]

 svnrdump: Make copyfrom data work and add corresponding passing test
 
 * subversion/svnrdump/load_editor.c
   (new_node_record): Use the data in the commit_edit_baton to
   construct a full URI for the copyfrom_path.
 
 * subversion/svnrdump/load_editor.h
   (commit_edit_baton): Import the edit_baton structure from commit.c
   since we need to derefence it to get out the repos_url.
 
 * subversion/tests/cmdline/svnrdump_tests.py
   (copy_and_modify, copy_and_modify_load, copy_and_modify_dump): Split
   the copy_and_modify test into two specialized tests: one for
   dumping, and another for loading. The load test should pass now.